Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding reencryption command to DKG #251

Merged
merged 36 commits into from
Jul 19, 2023
Merged

Adding reencryption command to DKG #251

merged 36 commits into from
Jul 19, 2023

Conversation

jbsv
Copy link
Contributor

@jbsv jbsv commented Apr 4, 2023

No description provided.

@jbsv jbsv marked this pull request as draft April 4, 2023 14:42
@coveralls
Copy link

coveralls commented Jun 5, 2023

Pull Request Test Coverage Report for Build 5597440153

  • 466 of 531 (87.76%) changed or added relevant lines in 7 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 98.73%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dkg/pedersen/pedersen.go 123 126 97.62%
dkg/pedersen/dkg.go 49 54 90.74%
dkg/pedersen/controller/action.go 77 83 92.77%
dkg/pedersen/types/messages.go 31 37 83.78%
dkg/pedersen/reencrypt.go 87 109 79.82%
dkg/pedersen/json/json.go 82 105 78.1%
Files with Coverage Reduction New Missed Lines %
dkg/pedersen/pedersen.go 1 96.31%
mino/minogrpc/server.go 2 99.33%
Totals Coverage Status
Change from base Build 5266121109: -0.4%
Covered Lines: 14618
Relevant Lines: 14806

💛 - Coveralls

@jbsv jbsv self-assigned this Jun 5, 2023
@jbsv jbsv marked this pull request as ready for review June 5, 2023 11:59
@jbsv jbsv requested a review from pierluca June 5, 2023 12:00
Copy link
Contributor

@pierluca pierluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch of review :)

dkg/dkg.go Outdated Show resolved Hide resolved
dkg/dkg.go Outdated Show resolved Hide resolved
dkg/pedersen/controller/action.go Outdated Show resolved Hide resolved
dkg/pedersen/controller/controller.go Outdated Show resolved Hide resolved
dkg/pedersen/dkg.go Outdated Show resolved Hide resolved
dkg/pedersen/pedersen.go Outdated Show resolved Hide resolved
dkg/pedersen/pedersen.go Outdated Show resolved Hide resolved
dkg/pedersen/pedersen_test.go Show resolved Hide resolved
dkg/pedersen/pedersen_test.go Outdated Show resolved Hide resolved
dkg/pedersen/pedersen_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@pierluca pierluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meta-comment:
I'm wondering, does it make sense to add Calypso-specific stuff to our Pedersen's implementation, or should we do a Calypso-specific DKG (in its own repo) using this implementation and extending it ? 🤔
I'm just a bit worried of overspecializing our Pedersen implementation while at the same time slowing down our development (because I'll tend to be slightly more annoying on the Dela repo, since it's the foundation for everything else)

dkg/dkg.go Outdated Show resolved Hide resolved
dkg/dkg.go Show resolved Hide resolved
dkg/pedersen/ocs.go Outdated Show resolved Hide resolved
}

// DecryptSecret implements dkg.Actor.
func (a *Actor) DecryptSecret(Cs []kyber.Point, XhatEnc kyber.Point, Sk kyber.Scalar) (msg []byte, err error) {
Copy link
Contributor

@pierluca pierluca Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we misunderstood each other 😅

I didn't mean the OCS (although it's probably a good thing that you have split it out).

I meant the secret decryption seems off here (as we discussed in person yesterday), and it probably makes more sense into its own (client) library.

@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

89.6% 89.6% Coverage
0.7% 0.7% Duplication

@jbsv jbsv merged commit 94a2e36 into master Jul 19, 2023
7 checks passed
@jbsv jbsv deleted the dkg-reencrypt branch July 19, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants