Adding reencryption command to DKG #251
Conversation
Pull Request Test Coverage Report for Build 5597440153
💛 - Coveralls |
There was a problem hiding this comment.
Meta-comment:
I'm wondering, does it make sense to add Calypso-specific stuff to our Pedersen's implementation, or should we do a Calypso-specific DKG (in its own repo) using this implementation and extending it ? 🤔
I'm just a bit worried of overspecializing our Pedersen implementation while at the same time slowing down our development (because I'll tend to be slightly more annoying on the Dela repo, since it's the foundation for everything else)
dkg/pedersen/pedersen.go
Outdated
| } | ||
|
|
||
| // DecryptSecret implements dkg.Actor. | ||
| func (a *Actor) DecryptSecret(Cs []kyber.Point, XhatEnc kyber.Point, Sk kyber.Scalar) (msg []byte, err error) { |
There was a problem hiding this comment.
I think we misunderstood each other 😅
I didn't mean the OCS (although it's probably a good thing that you have split it out).
I meant the secret decryption seems off here (as we discussed in person yesterday), and it probably makes more sense into its own (client) library.
|
Kudos, SonarCloud Quality Gate passed! |
No description provided.